Performance Question about service instnace : getInstance(i Injector) (T, error)

[kcmvp]

func (s *serviceEager[T]) getInstance(i Injector) (T, error) {
    frame, ok := stacktrace.NewFrameFromCaller()
    if ok {
        s.mu.Lock()
        s.invokationFrames = append(s.invokationFrames, frame) // @TODO: potential memory leak
        s.mu.Unlock()
    }

    return s.instance, nil
}

above code is from https://github.com/samber/do/blob/v2-%F0%9F%9A%80/service_eager.go,

right now I am using do by generate a global singleton scope and get the service on demand. but there is a call to get call stack everytime I try to get the instnace frame, ok := stacktrace.NewFrameFromCaller(), in fact this methos is not exported just for internal usagae. It will decrease the system performance. is there way to optimize the design?

[samber]

3 ideas come to my mind:

• add a parameter in the root scope
• add a parameter globally in the lib (eg: do.TraceInvocation = true)
• enable only if a debugging library is loaded (like github.com/samber/do/http/gin/v2)

I'm adding this to v2.1 roadmap.