search

samber / git-contrib-graph

📊 Displays a github-like contribution graph, of every contributors of a repository
10 stars 11 forks source link

Add test and dependency management tool #22

Closed DanielDanteDosSantosViana closed 5 years ago

DanielDanteDosSantosViana commented 5 years ago

Issue #12 add test to function getTotalsByAuthor.

I think is more easy when work with other libs use a dependency management tool, because when anybody get your project the setup is only run command 'dep ensure'. =)

DanielDanteDosSantosViana commented 5 years ago

You use go mod ? hummm i don't use go version 1.11.. =/

here are discussing about these technologies

samber commented 5 years ago

Thanks for suggesting dep, but I think we will use go mod here (future proof ?).

Could you rebase on master and check if tests are still passing ? Can you add tests to CI please ? 🙏

DanielDanteDosSantosViana commented 5 years ago

done. but i don't add in CI... created a other issue #23 to add test in CI