search

samber / git-contrib-graph

📊 Displays a github-like contribution graph, of every contributors of a repository
10 stars 11 forks source link

Fix all style warnings #24

Closed citizen428 closed 5 years ago

citizen428 commented 5 years ago

Go is a pretty opinionated language and I find it's generally better to follow the community standards, so I changed everything according to the official style guides (camel case names, no unnecessarily exported stuff etc).

samber commented 5 years ago

good idea !

Can you capitalize the first letter of types ? Stats, TotalStats...

citizen428 commented 5 years ago

Can you capitalize the first letter of types ? Stats, TotalStats

I can, but it would sort of be against the spirit of this PR, since we'll just re-introduce warnings like this one:

exported type Stats should have comment or be unexported

samber commented 5 years ago

Ok, let's merge ;)