search

samber / lo

💥 A Lodash-style Go library based on Go 1.18+ Generics (map, filter, contains, find...)
https://pkg.go.dev/github.com/samber/lo
MIT License
17.99k stars 828 forks source link

Keys: accept multiple maps (vaargs) #452

Open samber opened 6 months ago

samber commented 6 months ago

From

lo.Keys[K comparable, V any](in map[K]V) []K

to

lo.Keys[K comparable, V any](in ...map[K]V) []K

In case of collision, deduplicate keys?

shivamrazorpay commented 4 months ago

Hey @samber I want to add a PR to resolve this issue. Can I get access to adding a PR for this issue ??

Also, I can see the Test of Keys is incorrect as it sorts the keys before asserting them, but there is no sort in the Keys function. I will also fix them.

shivamrazorpay commented 4 months ago

@ccoVeille I want to be a contributor. Can you help me to get access? I can fix this issue and some other open issues. Thank you. 😊

ccoVeille commented 4 months ago

I don't have much access than you do I think. I'm just a compulsive code reviewer. That's why you see me active.

You just have to fork the repository, push a branch on it, then open a PR mentioning the issue you want to fix.

I can review a PR if you open one.

shivamrazorpay commented 4 months ago

@ccoVeille by seeing your code reviews, I was amazed at how much good you are doing. I would love to chat with you one day. Can you also review my PR? Thank you.

ccoVeille commented 4 months ago

you are nice, thanks.

You can join the slack workspace of the gophers. You will find the link on my GitHub profile. So we can talk there

Edit: here is the link https://gophers.slack.com/team/U03FE6TMKPX

dagenius007 commented 4 months ago

Hello @ccoVeille how do I join the gophers slack channel?

ccoVeille commented 4 months ago

Click on the link I provided, create an account if needed, install slack if needed.

If it doesn't work, try with this link

https://join.slack.com/t/gophers/shared_invite/zt-2lmem2ic2-EfbtKK9FGlBHHgeEu0an7Q

The link is valid for 4 days

cc @dagenius007

Luigi31415 commented 1 day ago

@samber This was resolved in #503, I think we should close this issue