Strat implementing EitherX for X between 3 and 5

samber / mo

🦄 Monads and popular FP abstractions, powered by Go 1.18+ Generics (Option, Result, Either...)

https://pkg.go.dev/github.com/samber/mo

MIT License

2.47k stars 80 forks source link

Strat implementing EitherX for X between 3 and 5 #10

Closed CorentinClabaut closed 1 year ago

CorentinClabaut commented 1 year ago

I have only implemented Either5 so far.

@samber Could you do a quick PR before I duplicate the code for Either3 and Either4 ?

I was thinking of leaving the README.md and either5_example_test.go as it is and just add either3.go, either4.go, either3_test.go and either4_test.go.

I think that should be enough that way, WDYT?

samber commented 1 year ago

LGTM

I made a small comment on README.

I think you can move forward. I agree, don't bother with either3_example_test.go nor either4_example_test.go.

CorentinClabaut commented 1 year ago

@samber I have added Either3 and Either4.

Also, I think you forgot to push your comment on the README.