Open DylanRJohnston-FZ opened 1 year ago
Ok, I see. 👍
I will mark this issue with a "breaking-change" tag, for preparing v2. Please create an issue for any unexpected API. 🙏
Let solves all these little things before a new major release later this year!
Just wanted to give a +1 on this, coming from cats and Scala this map implementation had me scratching my head a bit.
Taeekkkk
Firstly I just want to say that I love this library and has allowed to me to largely remove my own custom implementation of a lot of these types. However I was wondering what the reasoning behind the signature and behaviour of
(mo.Option).Map
?Generally speaking
Map
called on aSome
should always return aSome
which is a sentiment you also shared here. The ability to returnfalse
within themapper
makesMap
behave more likeFlatMap
. It also makes passing point-free functions a little awkward as you have to "lift" the mapper into that signature. e.g.I propose that
(mo.Option).Map
's signature should be changed to remove the boolean argument, if someone wants the old behaviour they can useFlatMap
andTupleToOption
.