samber / mo

🦄 Monads and popular FP abstractions, powered by Go 1.18+ Generics (Option, Result, Either...)
https://pkg.go.dev/github.com/samber/mo
MIT License
2.61k stars 85 forks source link

fix(option): correct IsPresent IsAbsent docstrings #22

Closed mosiman closed 1 year ago

mosiman commented 1 year ago

The original docstrings for IsPresent and IsAbsent seemed wrong, or at the very least confusing. Let me know if I'm completely off base here!

samber commented 1 year ago

argh

thanks for the fix :-(

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (d2b2b60) 88.98% compared to head (0b29bdd) 88.98%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #22 +/- ## ======================================= Coverage 88.98% 88.98% ======================================= Files 13 13 Lines 1080 1080 ======================================= Hits 961 961 Misses 107 107 Partials 12 12 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `88.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Berthe#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/samber/mo/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Berthe) | Coverage Δ | | |---|---|---| | [option.go](https://codecov.io/gh/samber/mo/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Berthe#diff-b3B0aW9uLmdv) | `91.03% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Berthe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Berthe)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.