search

samber / mo

🦄 Monads and popular FP abstractions, powered by Go 1.18+ Generics (Option, Result, Either...)
https://pkg.go.dev/github.com/samber/mo
MIT License
2.47k stars 80 forks source link

Downgrade the goleak version to one that is compatible with the go version #44

Closed taman9333 closed 4 weeks ago

taman9333 commented 4 weeks ago

The Golang version, along with some dependencies, has been upgraded here. However, in a later commit, the Golang version was downgraded again to 1.18 without the dependencies.

Currently, the CI will fail when running tests due to this error

# go.uber.org/goleak/internal/stack
../../../.asdf/installs/golang/1.18/packages/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:123:26: undefined: errors.Join
../../../.asdf/installs/golang/1.18/packages/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:256:26: undefined: strings.CutPrefix
note: module requires Go 1.20
taman9333 commented 4 weeks ago

@samber

samber commented 4 weeks ago

Ok, thanks for your help. I was struggling with that issue earlier today.