Cleanup code - Githubissues

sambernard / react-preload

Component to preload images before showing content

MIT License

148 stars 48 forks source link

Cleanup code #22

Closed Mesoptier closed 6 years ago

Mesoptier commented 7 years ago

Added react and react-dom to devDependencies. As they are used during development.
Updated ESLint and related packages.
Updated .eslintrc and fixed code in modules/

wagmiwiz commented 7 years ago

Hey hey. Any chance of also doing the React 15.5 PropTypes cleaned up as part of this? It is the only offending module that still spits out the warning for me 😁

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

ohall commented 7 years ago

@Mesoptier @nikbora prop-types here https://github.com/sambernard/react-preload/pull/23

RWOverdijk commented 7 years ago

I've made a fork of this plugin. It works the same but has the PRs that cleanup and fix the PropTypes merged in. You can find it here.

sambernard commented 6 years ago

A (belated) thanks for your contribution!