search

sambernard / react-preload

Component to preload images before showing content
MIT License
148 stars 48 forks source link

Use the prop-types package instead of deprecated PropTypes from React #23

Closed ohall closed 6 years ago

ohall commented 7 years ago

Use the prop-types package instead of deprecated PropTypes from main React Package.

screen shot 2017-05-24 at 3 36 23 pm

Thanks!

wagmiwiz commented 7 years ago

Hey @sambernard, any chance of merging this in and bumping up the version? Red consoles are so 2016.

NeXTs commented 6 years ago

@sambernard Hey Sam, please spend a minute to accept and publish this PR.

It's quite important for those of us who want to migrate to react v16

malikid commented 6 years ago

Hi guys, you can simply set npm package to

"react-preload": "git+https://github.com/malikid/react-preload.git"

before this PR is merged. It's forked from ohall:master and built.

RWOverdijk commented 6 years ago

I've made a fork of this plugin. It works the same but has the PRs that cleanup and fix the PropTypes merged in. You can find it here.

nuclearspike commented 6 years ago

Is this package abandoned? There are completed PRs to fix issues that were completed months ago...

hiradyazdan commented 6 years ago

is there any update on this?

RWOverdijk commented 6 years ago

https://www.npmjs.com/package/react-preloaded ^

sambernard commented 6 years ago

Hi! My apologies- I haven't been using this github account for the last 14 months so I missed the activity on this repo. I'll go ahead and go through these PRs/issues today.