search

sambernard / react-preload

Component to preload images before showing content
MIT License
148 stars 48 forks source link

Using a fake image throws an error in the console but onError is not called #25

Closed jrmyio closed 6 years ago

jrmyio commented 7 years ago

I am using a preload on a non-existing image.

I get the error in the console: ImageHelper.js:67 failed to preload images/test.pxz

However, the onError is not called whereas onSuccess is. I have resolveOnError also turned off.

This is happening since 5.1, 5.0 was fine.

sambernard commented 6 years ago

This is fixed in https://github.com/sambernard/react-preload/commit/62f9a08f509546234de0c91033fec75cc39cfac4 and will be in the next release.