search

sambernard / react-preload

Component to preload images before showing content
MIT License
148 stars 48 forks source link

Move the "images failed to load" message out of _handleSuccess #27

Closed erinknight242 closed 6 years ago

erinknight242 commented 7 years ago

As suggested by @Mesoptier, I moved the "images failed to load" warning out of the general _handleSuccess function, so it only appears when the timeout has actually been passed instead of just because a timeout parameter had been set.

This resolves issue #17 .

sambernard commented 6 years ago

Thanks for this! I've resolved this instead by removing the message completely as it doesn't provide anything useful.