search

sambhav2612 / karumanchi

:satisfied: DS Problems from karumanchi. This repository follows the C++ Best Practices written by Jason Turner.
https://sambhav2612.github.io/karumanchi/
GNU Affero General Public License v3.0
5 stars 7 forks source link

Update Makefile #1

Open sambhav2612 opened 6 years ago

sambhav2612 commented 6 years ago

The current makefile is not working correctly. The intention of the script is to compile all .cpp files in every sub-directory from the root of the project. This is the output I'm currently getting in WIndows 10 with Cygwin environment:

$ make all
g++ -g -O -Wall  ./ch1-introduction ./ch10-sorting ./ch2-recursion-and-backtracking ./ch3-linked-lists ./ch4-stacks ./ch5-queues ./ch6-trees ./codechef/arrays -o all
./ch1-introduction: file not recognized: Is a directory
collect2: error: ld returned 1 exit status
Makefile:12: recipe for target 'all' failed
make: *** [all] Error 1

Please send PR to the update-makefile branch!

sambhav2612 commented 6 years ago

I was using wildcard functions to accomplish the same, however, any different approach is more than welcome!

P.S. For reference - https://stackoverflow.com/questions/14028268/proper-method-for-wildcard-targets-in-gnu-make

piba941 commented 5 years ago

@sambhav2612 i would like to take up this issue.

sambhav2612 commented 5 years ago

Sure, go ahead @piba941!

satyamroy001 commented 4 years ago

Any issues for me @sambhav2612 please tell me

sambhav2612 commented 4 years ago

@satyamroy001 sure go ahead!

satyamroy001 commented 4 years ago

I have made the pull check it out

On Mon, 7 Oct 2019, 12:31 pm Sambhav Jain, notifications@github.com wrote:

@satyamroy001 https://github.com/satyamroy001 sure go ahead!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sambhav2612/karumanchi/issues/1?email_source=notifications&email_token=AK4PZFRYPCTZGWLGPAP5HODQNLNE5A5CNFSM4FILG5P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPG54A#issuecomment-538865392, or mute the thread https://github.com/notifications/unsubscribe-auth/AK4PZFV2EK6CAOPEMY2KTRDQNLNE5ANCNFSM4FILG5PQ .