search

sambit-giri / tools21cm

MIT License
22 stars 19 forks source link

Mistake in setup.py? #24

Closed garrelt closed 2 years ago

garrelt commented 2 years ago

The setup.py file has 'git+https://github.com/sambit-giri/cosmospectra.git' in the list of requirements. This generates an error when I try to install it with pip 20.3.4. It seems this string should instead be 'cosmospectra @ git+https://github.com/sambit-giri/cosmospectra.git'. See https://stackoverflow.com/questions/60414753/how-to-install-githttps-from-setup-py-using-install-requires

sambit-giri commented 2 years ago

Thank for the fix. I have implemented it now. Can you try to install it again directly using pip?

sambit-giri commented 2 years ago

Just to make a note about cosmospectra. It is a separate package that contains modules to calculate not only the power spectrum but also the higher-order statistics.

garrelt commented 2 years ago

The installation works with this change,