search

sambit-giri / tools21cm

MIT License
22 stars 18 forks source link

Cosmology definition #55

Open garrelt opened 1 week ago

garrelt commented 1 week ago

Tools21cm seems to define the type of cosmology in many different places. temperature.py astro_tools.py lyman_alpha_transmission.py nbody_tools.py line_intensity.py all define Planck18 as the default. It would be much better if this was defined in only one place. This makes sure that there's no unwanted inconsistencies and also makes it easier to adapt the code if the latest version of astropy is not available.

sambit-giri commented 1 week ago

I am aware of this inconsistency. @micbia and I want to make tools21cm use astropy.cosmology for cosmological calculation. Therefore the new modules have a parameter called cosmo to take a astropy.cosmology object. We will make this consistent.