search

sambitdash / PDFIO.jl

PDF Reader Library for Native Julia.
Other
127 stars 13 forks source link

Another approach to remove the type instability #105

Closed sambitdash closed 2 years ago

sambitdash commented 2 years ago

To be reviewed along with #104. Pre-create the objects and deepcopy when needed.

sambitdash commented 2 years ago

@hhaensel please review this with test cases and see if there is any performance improvement.

hhaensel commented 2 years ago

Hi, sorry it took me so long to come back to this topic. It seems that your approach has identical memory usage and speed as mine. I had first tested your approach but forgot to do a deepcopy, so I failed. I think we should rather go for your approach then. I'll close #104 then.