search

sambitdash / PDFIO.jl

PDF Reader Library for Native Julia.
Other
127 stars 13 forks source link

Support for AbstractTrees v0.3 #98

Closed Nosferican closed 3 years ago

Nosferican commented 3 years ago

The test for Outlines fails with AbstractTrees v0.3 fixing it at v0.2. This makes it that other packages that rely on the dependency like DataFrames.jl are held back at v0 preventing it from using v1 in the same environment. Would be nice if the issue can be fixed such that the deps can allow for AbstractTrees v0.3. Thanks!

PS: BinDeps v1 seems to be working with the package w/no issues.

sambitdash commented 3 years ago

@Nosferican feel free to send a PR if you have a solution that can address the issue.

Nosferican commented 3 years ago

I tried to see if it was something trivial but couldn't tell how exactly how AbstractTrees was impacting the test case.

sambitdash commented 3 years ago

Fixed in: https://github.com/sambitdash/PDFIO.jl/commit/64628309fea6e8f00834072a1ebd25760b8952f6