search

samccauley / addon-hassiogooglebackup

A hass.io add-on to backup snapshots to Google Drive
MIT License
90 stars 12 forks source link

Add CI addon config lint #37

Closed TheZoker closed 3 years ago

TheZoker commented 3 years ago

Frenck wrote a little Github action, that lints the config file of addons: https://github.com/frenck/action-addon-linter

This PR implements that linter via Github CI and also removes one parameter, that had the default value (according to the linter) and could therefore be removed.

The result for the first run of the CI can be seen here: https://github.com/TheZoker/addon-hassiogooglebackup/actions/runs/549002514

samccauley commented 3 years ago

@TheZoker I appreciate you bringing Frenck's add-on linter to my attention. I've been meaning to add CI actions for my add-on.

I'm puzzled by one thing his Linter does. It seems to require that the version in the config.json file be "dev". Why would that be? Why not allow specific version numbers?

I realize it is not your linter, but Frenck's. But since you're recommending it, I thought you might be able to help me understand.

Thank you!

TheZoker commented 3 years ago

Hi @samccauley

Unfortunately I don't know exactly why that is. I also saw that in your commit and I'm not sure. Maybe @frenck can help here?

frenck commented 3 years ago

It only requires that if community is set to true, which isn't in this case. The linter seems to pass, right?

samccauley commented 3 years ago

Yeah. I found that setting after posting my question. Thank you both for your help!

On Sat, Feb 13, 2021 at 2:12 PM Franck Nijhof notifications@github.com wrote:

It only requires that if community is set to true, which isn't in this case. The linter seems to pass, right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/samccauley/addon-hassiogooglebackup/pull/37#issuecomment-778664226, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHJRIQ7LMTO4HK5VCRUPU3S63FJNANCNFSM4XJRWVUQ .

TheZoker commented 3 years ago

@samccauley So should I close this PR since this is implement elsewhere?

samccauley commented 3 years ago

@TheZoker Yeah. I'm actually going to add several linters to automatically run through github actions. They're encouraging me to do much code clean-up - which I'm doing now. Thank you for putting the idea forth. You motivated me!

TheZoker commented 3 years ago

Glad to hear that 🙂 Keep up the good work 👍