search

samccone / drool

Automated memory leak detection and analysis
1.48k stars 53 forks source link

Doesn't work with chromedriver v >= 2.29 #32

Closed artemv closed 7 years ago

artemv commented 7 years ago

It doesn't detect leaks starting with chromedriver v 2.29 (checked with 2.30 and 2.31 too - same thing) - at least as per tests. Check Travis builds:

Looks like this is because drool don't get counts data starting from 2.29, https://github.com/samccone/drool/commit/cd4614df7922cb3f9aebb7bbcde11dcf59154024 kinda hides this issue - drool doesn't error in this case but becomes useless. If NPM published version 0.4.0 is used it errors instead:

TypeError: Cannot read property 'message' of undefined
    at /my/project/path/node_modules/drool/lib/index.js:40:27
    at ManagedPromise.invokeCallback_ (/my/project/path/node_modules/selenium-webdriver/lib/promise.js:1343:14)
    at TaskQueue.execute_ (/my/project/path/node_modules/selenium-webdriver/lib/promise.js:2868:14)
    at TaskQueue.executeNext_ (/my/project/path/node_modules/selenium-webdriver/lib/promise.js:2851:21)
    at asyncRun (/my/project/path/node_modules/selenium-webdriver/lib/promise.js:2730:27)
    at /my/project/path/node_modules/selenium-webdriver/lib/promise.js:639:7
    at process._tickCallback (internal/process/next_tick.js:103:7)