search

samccone / fidgetspin.xyz

https://fidgetspin.xyz
MIT License
299 stars 19 forks source link

chore(code): use prettier for consistent indenting #51

Closed Haroenv closed 7 years ago

Haroenv commented 7 years ago

I noticed that some things changed (tabs/spaces) when opening it in my editor, so I set up prettier for all typescript and javascript files. I noticed single quotes were preferred, so I set that setting in prettier.

Haroenv commented 7 years ago

Sure, that would be using prettier-eslint. I should take a look at how react did it.

Haroenv commented 7 years ago

@samccone I added a test, but I’m not 100% sure if it works correctly, could you enable travis on pull requests? I think it’s disabled

samccone commented 7 years ago

Hey @Haroenv I plan on landing this and all the big TS work this weekend, to minimize thrashing with rebasing :)

thanks so much for your prs thus far.

Haroenv commented 7 years ago

Sure. Lmk when to rebase

samccone commented 7 years ago

Landed as a7a8c6b2cea081c403bbff75f85d948e050547ca

Thanks again for your help here... super awesome