search

samccone / fidgetspin.xyz

https://fidgetspin.xyz
MIT License
299 stars 19 forks source link

feat(mouse): use mouse events when touch events don't work #56

Closed Haroenv closed 6 years ago

Haroenv commented 7 years ago

Mouse events work very similar to pointer events, so it’s just a question of adding event listeners

note: It made the ternaries slightly more complex now, but it's probably still fine

note: I spent like 30 minutes trying to debug this, until I cleared my cache in Safari and found that something kept it cached, even when I clicked "ignore cache" in the network tab. Weird/funny

depends on #51 to be merged first.

fixes #48

samccone commented 7 years ago

I went ahead and rebased and tried this, but it looks like it is not using the mousevents in safari https://github.com/samccone/fidgetspin.xyz/tree/mouse_events

Haroenv commented 7 years ago

It was working for me locally, did you make a now.sh deploy of this branch?

On 10 Jun 2017, at 17:20, Sam Saccone notifications@github.com wrote:

I went ahead and rebased and tried this, but it looks like it is not using the mousevents in safari https://github.com/samccone/fidgetspin.xyz/tree/mouse_events https://github.com/samccone/fidgetspin.xyz/tree/mouse_events — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samccone/fidgetspin.xyz/pull/56#issuecomment-307571389, or mute the thread https://github.com/notifications/unsubscribe-auth/AF-sYIvAxFNq0tZoPUy65gw6JOYVPdvfks5sCrQpgaJpZM4NzPke.

samccone commented 7 years ago

https://github.com/samccone/fidgetspin.xyz/pull/64