search

samccone / fidgetspin.xyz

https://fidgetspin.xyz
MIT License
299 stars 19 forks source link

Spin counter inaccurately reflects number of completed spins. #60

Open davmillar opened 7 years ago

davmillar commented 7 years ago

The spin counter seems to display a rounded version of a fractional number of spins completed. Because of this, a user can produce e.g. 1999.9 spins and see a score of 2000, but not have 'The Chu' spinner unlocked. Since only full spins count toward the unlock goals, the displayed score ought to display it floored instead of rounding to the closer integer.

samccone commented 7 years ago

Hmm, the code has no rounding logic in place for the spin count

update count: https://github.com/samccone/fidgetspin.xyz/blob/master/index.ts#L100 unlockedAt check https://github.com/samccone/fidgetspin.xyz/blob/master/index.ts#L396

Thoughts?