search

samccone / moji-brush

https://www.mojibrush.co
68 stars 7 forks source link

Undo should undo last stroke #26

Closed benlesh closed 8 years ago

benlesh commented 8 years ago

When I hit undo, I expected to undo the entire last stroke I did, and I thought maybe undo wasn't working. Took me a while to figure out that it was just doing one emoji at a time. Another side effect of this was that if you undo a lot in a row, it sort of locks up while it renders each undo.

benlesh commented 8 years ago

Actually, undoing stroke by stroke for more than just last stroke would be good. Keeping a history of mementos after each stroke would be cool, because you could undo each stroke you've done.

samccone commented 8 years ago

:+1:

joryphillips commented 8 years ago

This commit should have fixed that... it might need to be deployed to show up.

samccone commented 8 years ago

verified. I just needed to push the service worker force update code :)

if you open your app... close it... and open it ... it is good to go 💃

benlesh commented 8 years ago

Tried it last night, worked great!