search

samchon / nestia

NestJS Helper Libraries + TypeScript OpenAPI generator
https://nestia.io/
MIT License
1.76k stars 91 forks source link

Nestia route types broken on nest ^10.3.4 #837

Closed tjhiggins closed 5 months ago

tjhiggins commented 5 months ago

Summary

The latest version of nest added support for a RawBody route param. Which breaks the index lookup here: https://github.com/samchon/nestia/blob/20b41267bb9de92e2ee191623efada08c4917116/packages/sdk/src/analyses/ReflectAnalyzer.ts#L364

Suggestion

Import RouteParamtypes from Nest as opposed to hardcoding.

Code occuring the bug

https://github.com/samchon/nestia/blob/20b41267bb9de92e2ee191623efada08c4917116/packages/sdk/src/analyses/ReflectAnalyzer.ts#L460

https://github.com/nestjs/nest/blob/caf17246caeb65c0f56692774a5776accdb0d9cf/packages/common/enums/route-paramtypes.enum.ts#L6

samchon commented 5 months ago

Oops, this seems critical issue. I'll fix it ASAP.

samchon commented 5 months ago

@tjhiggins Upgrade to v2.5.16, then be fixed.

samchon commented 5 months ago

@tjhiggins Upgrade to v2.5.17 or v2.6.0. NestJS team did same thing again.

tjhiggins commented 5 months ago

@tjhiggins Upgrade to v2.5.17 or v2.6.0. NestJS team did same thing again.

Will do. Thanks for the heads up and fixes.