samclane / LIFX-Control-Panel

As LIFX no longer supports their Windows 10 app, I created an open-source alternative for controlling LIFX-brand smart lights.
https://github.com/samclane/LIFX-Control-Panel
MIT License
162 stars 19 forks source link

Unicode Alt keystrokes are not working #100

Closed tort32 closed 2 years ago

tort32 commented 3 years ago

Describe the bug When running the app, Alt keystrokes for Unicode symbols stop working.

Steps To Reproduce

  1. Run lifx_control_panel.exe
  2. Switch to an other app with text input (example Notepad.exe)
  3. Input Unicode sequence Alt+0153 (holding Alt key, press numpad digits, then release Alt key)
  4. Nothing appears in the text box

Expected behavior Unicode "Threadmark" symbol should appears after the keystroke.

image

Desktop:

Application is running normally, no keybinds are set by config. There is nothing particular in lifx-control-panel.log when reproducing the issue.

Looks like PyHook3.HookManager handling functions hinder system to process Unicode keystrokes. But I don't know this is incorrect event handling implementation or PyHook3 issue.

samclane commented 2 years ago

Since we switched to the keyboard library for keybinds, I'm wondering if this is still an issue.

Let me see if I can reproduce on the latest version.

tort32 commented 2 years ago

No issue with the latest release 2.1.0. Thank you 🌞