Fix for crash on startup when unknown device found and Avg. Screen Color not working

samclane / LIFX-Control-Panel

As LIFX no longer supports their Windows 10 app, I created an open-source alternative for controlling LIFX-brand smart lights.

https://github.com/samclane/LIFX-Control-Panel

MIT License

161 stars 19 forks source link

Fix for crash on startup when unknown device found and Avg. Screen Color not working #134

Closed AnthonyANI closed 2 years ago

AnthonyANI commented 2 years ago

I've added some small exception handling to main to catch KeyError exceptions for when unknown LIFX devices are found (not in LIFXLAN's products). This prevented me from starting the app because I have a LIFX Switch that shows up as 116.

AnthonyANI commented 2 years ago

Also restored Avg. Screen Color functionality. This was changed in this commit, but the param "initial_color_hsbk" was invalid for the call done by color_thread which passes argument "initial_color".

samclane commented 2 years ago

Wow, thank you for taking the time to fix this! Must've been a bad refactor/renaming of variables.

AnthonyANI commented 2 years ago

Of course! I enjoy this app often with games and movies, for that extra immersion. 😁 It's pretty quick to change the lights to what's on screen without hitting heavy game FPS too hard, which is nice. I appreciate all the hard work! Glad I could help!