Closed Energiz3r closed 2 years ago
Merging #136 (2d2d480) into master (894f9c3) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 58.81% 58.81%
=======================================
Files 4 4
Lines 573 573
=======================================
Hits 337 337
Misses 236 236
Flag | Coverage Δ | |
---|---|---|
unittests | 58.81% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 894f9c3...2d2d480. Read the comment docs.
I'm not sure why Codecov reports such a large decrease in coverage of unit test but surely it's not 55%... regardless it might be wise to resolve your question regarding the global variables before writing a unit test for the color_cycle function
Sorry work has been hectic.
I see that Pyinstaller is failing the smoke. Speaking of work, I've just dealt with the same issue.
I think the change that doesn't allow for spec
files with --onefile
parameter is a recent change. I'll find a workaround- the bat
file was a hacky/platform-dependent choice.
@Energiz3r I made some PRs to your Fork that address the issues.
I'm still not sure why the CodeCov dropped; even on my recent push to master
where I just pinned the Pyinstaller version, the coverage still plummeted to 3%. I'll ignore it for now.
Hi there,
I've added a color cycle effect to the app. To make this function smoothly as intended, I've bumped the default transition speed setting in default.ini from 0.00 seconds to 0.07. This seemed to have no noticeable impact on any other effects or settings - although notably did have a positive impact on use of the Music and Dominant Screen effects.
A setting to adjust the speed of the color cycle effect is desirable but a little beyond my understanding of the code used for the UI.
Cheers Energiz3r