samclarke / SCEditor

A lightweight HTML and BBCode WYSIWYG editor
http://www.sceditor.com/
Other
657 stars 187 forks source link

Feature for adding target type option for `link`/anchor tag in the toolbar #842

Open jtoloui-ibm opened 3 years ago

jtoloui-ibm commented 3 years ago

Is your feature request related to a problem? Please describe. When using SCEditor and using link option from the toolbar it doesn't allow a user to select its target type to specific how you wish the link to open the url e.g same window or in a new page or tab.

Describe the solution you'd like The option within SCEditor dropdown for link to have the choice of the types of target types an anchor tag can have.

Describe alternatives you've considered Another option I've seen is to go into the code mode and manually edit/add a target attribute however when exiting code mode it reverts those changes

Additional context N/A

jtoloui-ibm commented 3 years ago

Hi @samclarke, I've create a fix but it won't let me publish the branch, would it be possible to be allowed to push?

live627 commented 3 years ago

Did you try to push to your own fork?

On Fri, Aug 13, 2021 at 1:20 AM Jamie T @.***> wrote:

Hi @samclarke https://github.com/samclarke, I've create a fix but it won't let me publish the branch, would it be possible to be allowed to push?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/samclarke/SCEditor/issues/842#issuecomment-898278392, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJNN7M2EI5IAEUQKUWSL3T4TIWRANCNFSM5CBL7CKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

jtoloui-ibm commented 3 years ago

No my mistake, forking now thanks

jtoloui-ibm commented 3 years ago

Created a plugin in #844 to include into the next 3.X release being a non breaking change