search

samcorcos / meteor-react-ionic-basic

52 stars 17 forks source link

clean the scss import #3

Open rdewolff opened 8 years ago

rdewolff commented 8 years ago

Hi @samcorcos

Thanks for sharing your work.

Am wondering how we could "clean" the following scss file import :

https://github.com/samcorcos/meteor-react-ionic-basic/blob/master/client/styles/styles.scss#L1-L2

I just ran a meteor update and the @import are not working anymore.

Any idea how to do that properly and how to fix the error?

Error :

=> Errors prevented startup:

   While processing files with fourseven:scss (for target web.browser):
   /client/views/index.scss: Scss compiler error: File to import:
   {}/client/views/.meteor/local/build/programs/server/assets/packages/meteoric_ionic-sass/ionic not found in file:
   /Users/rdewolff/Projets/meetme-mobile/{}/client/views/index.scss

   While processing files with fourseven:scss (for target web.cordova):
   /client/views/index.scss: Scss compiler error: File to import:
   {}/client/views/.meteor/local/build/programs/server/assets/packages/meteoric_ionic-sass/ionic not found in file:
   /Users/rdewolff/Projets/meetme-mobile/{}/client/views/index.scss
samcorcos commented 8 years ago

Hmm, yeah we'll have to change that to something else. Perhaps the best solution is to copy-paste it into the project directory.

On Sat, Oct 31, 2015 at 10:25 AM Romain de Wolff notifications@github.com wrote:

Hi @samcorcos https://github.com/samcorcos

Thanks for sharing your work.

Am wondering how we could "clean" the following scss file import :

https://github.com/samcorcos/meteor-react-ionic-basic/blob/master/client/styles/styles.scss#L1-L2

I just ran a meteor update and the @import are not working anymore.

Any idea how to do that properly and how to fix the error?

Error :

=> Errors prevented startup:

While processing files with fourseven:scss (for target web.browser): /client/views/index.scss: Scss compiler error: File to import: {}/client/views/.meteor/local/build/programs/server/assets/packages/meteoric_ionic-sass/ionic not found in file: /Users/rdewolff/Projets/meetme-mobile/{}/client/views/index.scss

While processing files with fourseven:scss (for target web.cordova): /client/views/index.scss: Scss compiler error: File to import: {}/client/views/.meteor/local/build/programs/server/assets/packages/meteoric_ionic-sass/ionic not found in file: /Users/rdewolff/Projets/meetme-mobile/{}/client/views/index.scss

— Reply to this email directly or view it on GitHub https://github.com/samcorcos/meteor-react-ionic-basic/issues/3.

pors commented 8 years ago

If you add the meteoric packages without explicitly adding the fourseven:scss package (i.e. meteor add meteoric:ionic-sass meteoric:ionicons-sass) a meteor update will not update the fourseven:scss package (unless you explicitly provide a new version).

meteoric:ionic-sass relies on a specific version of fourseven:scss.