search

samdark / intellij-visual-studio-code-dark-plus

Visual Studio Code Dark Plus theme for JetBrains IDEs
https://plugins.jetbrains.com/plugin/12255-visual-studio-code-dark-plus-theme
BSD 3-Clause "New" or "Revised" License
139 stars 31 forks source link

macOS Menu Separator Color #12

Closed rynpsc closed 4 years ago

rynpsc commented 4 years ago

On macOS the menu separator has a secondary fill above and below which I don't think is intentional. Not familiar with Intellij theming so not sure what setting needs to be changed.

macOS-menu
samdark commented 4 years ago

I have it slightly less visible:

image

323232 is the overall background color. An element should be found via http://www.jetbrains.org/intellij/sdk/docs/reference_guide/internal_actions/internal_ui_lafd.html

samdark commented 4 years ago

Or... it may be ContrastBorderColor reused. Then have to check what else would be affected by changing it.

rynpsc commented 4 years ago

After discovering the LaF panel I've been able to narrow in down to PopUpMenu.background, setting that to #323232 resolves it.

I've also experimented with making the separator narrower with:

PopUpMenuSeparator.height: 13
PopUpMenuSeparator.stripeIndent: 6
PopUpMenuSeparator.stripeWidth: 1
macOS-menu-v2
reksc commented 4 years ago

@rynpsc thanks for sharing your discovery. For me the right color code for PopUpMenu.background was #242425. Took your separator adjustments and the result is awesome.

samdark commented 4 years ago

@rynpsc looks awesome. Want to submit a pull request?

samdark commented 4 years ago

13