search

samdark / intellij-visual-studio-code-dark-plus

Visual Studio Code Dark Plus theme for JetBrains IDEs
https://plugins.jetbrains.com/plugin/12255-visual-studio-code-dark-plus-theme
BSD 3-Clause "New" or "Revised" License
141 stars 31 forks source link

GoLang text colors wrong #15

Closed garrettporter closed 4 years ago

garrettporter commented 4 years ago

The text color scheme in this plug is not similar to the VS Code Dark+ (default) color scheme.

GoLand image

VSCode image

samdark commented 4 years ago

I haven't checked Golang in detail when developing the schema. It seems to be good enough for PHP, Java, JavaScript, CSS, XML, HTML.

You can adjust the schema in Settings -> Editor -> Color Scheme -> Go. Then export it in .icls. That would give you XML to merge into https://github.com/samdark/intellij-visual-studio-code-dark-plus/blob/master/resources/visual_studio_code_dark_plus.xml

garrettporter commented 4 years ago

@samdark In VS Code "func" and "return" are different colors, however GoLand classifies both of them as language keywords, so they share a color. Is there a workaround for making them different colors?

samdark commented 4 years ago

@Grehgous not that I'm aware of. That's the same with other languages. Colors are not precise but close.

garrettporter commented 4 years ago

PR has been started. https://github.com/samdark/intellij-visual-studio-code-dark-plus/pull/16 I can't seem to link it to this issue.

samdark commented 4 years ago

Thanks. I'll re-check it and merge. Then release new version. May take some time.

samdark commented 4 years ago

Adjusted, fixed and merged. Will be available from JetBrains after pre-moderation period (usually within days).