search

samdark / intellij-visual-studio-code-dark-plus

Visual Studio Code Dark Plus theme for JetBrains IDEs
https://plugins.jetbrains.com/plugin/12255-visual-studio-code-dark-plus-theme
BSD 3-Clause "New" or "Revised" License
141 stars 31 forks source link

Adjust JSDoc colors #37

Closed amstiel closed 3 years ago

amstiel commented 3 years ago

I adjusted some DEFAULT_DOC colors to match VSCode ones (probably was legacy from Darcula). So JSDoc tags can inherit correct ones now.

Q A
Is bugfix? ✔
New feature? ✔
PhpStorm before VSCode PhpStorm after
Screen Shot 2021-03-03 at 22 49 19 Screen Shot 2021-03-03 at 22 49 48 Screen Shot 2021-03-03 at 22 53 37

Default doc adjustments:

Params before Params after Markup tags before Markup tags after (matched with xml/html colors)
Screen Shot 2021-03-03 at 22 50 34 Screen Shot 2021-03-03 at 22 53 16 Screen Shot 2021-03-03 at 23 11 51 Screen Shot 2021-03-03 at 22 55 33
samdark commented 3 years ago

Awesome PR and especially thanks for before/after comparison. More adjustments to follow or building a release?

amstiel commented 3 years ago

@samdark Thanks for feedback! You can build a release. I have plans for future improvements, but not now 😄