samdark / intellij-visual-studio-code-dark-plus

Visual Studio Code Dark Plus theme for JetBrains IDEs
https://plugins.jetbrains.com/plugin/12255-visual-studio-code-dark-plus-theme
BSD 3-Clause "New" or "Revised" License
139 stars 31 forks source link

Tab color in new UI is wrong in some IDEs #57

Closed samdark closed 1 year ago

samdark commented 1 year ago

IDEA 2023.1.1 (Ultimate Edition):

68747470733a2f2f692e696d6775722e636f6d2f6e516b6a726a312e706e67

WebStrom 2023.1.1:

237209334-0125df52-e980-4ab3-80d2-b0123d0ab696

Rider:

237209348-85b00a81-28fb-4c62-b87a-099ebe33cb4c

See #56

jsodeman commented 1 year ago

I can't recall the details but when I was looking for a way to change the tab highlighting I came across a few tickets in YouTrack regarding the new UI ignoring some of the tab related color scheme settings.

Fokrychel commented 1 year ago

hah, same question, werid

jsodeman commented 1 year ago

This is the YouTrack ticket I was referring to:

https://youtrack.jetbrains.com/issue/IDEA-307289/Selected-Tab-Background-Color-not-working-in-new-UI

rtm516 commented 1 year ago

I get this with the 'old' UI on IntelliJ Idea 2023.1.1 since the 2.7 release and this commit https://github.com/samdark/intellij-visual-studio-code-dark-plus/commit/47c3184908ff90d951e462fe89e884a2d2777f37

patrickteng commented 1 year ago

Same issue here on PhpStorm. Needed to use a plugin to override it

Screenshot 2023-05-11 at 11 16 10 AM

jsodeman commented 1 year ago

@patrickteng This one? https://plugins.jetbrains.com/plugin/9562-active-tab-highlighter

patrickteng commented 1 year ago

@jsodeman yes, currently using that, but still slightly buggy (it goes to default pink color if i navigate to other apps, but reverts to the color i set after clicking on another tab). Still better than the bright blue on the vsc-dark-plus currently.

samdark commented 1 year ago

Alright. I can reproduce it with PhpStorm 2023.1.1 and new UI:

image
maples3 commented 1 year ago

For what it's worth, I'm also seeing this in PhpStorm 2023.1.1 with the old UI enabled, after updating the theme plugin to version 2.7. image

Manually downloading and reinstalling version 2.6 fixes the issue

jsodeman commented 1 year ago

I just updated to 2023.1.2 in both WebStorm and Rider and it looks like the active tab identification is fixed in both.

Edit: in the NewUI

WebStorm image

Rider image

samdark commented 1 year ago

PhpStorm 2023.1.2.

Old UI:

image

New UI:

image
jsodeman commented 1 year ago

@samdark That's progress though right? :-) At least there's a version that works for each.

MichalVasut commented 1 year ago

PhpStorm 2023.1.2.

Old UI:

image

New UI:

image

Same happens in PyCharm 2023.1.2 (Professional Edition)

ooooo84 commented 1 year ago

This issue is came back after upgrade to 2023.1.3, tested in IDEA and WebStorm. The UI is same as the initial post. Downgrade to 2.6 and use old UI works fine.

DonPuh commented 1 year ago

After updating PhpStorm to version 2023.1.3 the problem returned.

bug_color_tabs

samdark commented 1 year ago

Will be fixed in the upcoming release.