search

samdark / intellij-visual-studio-code-dark-plus

Visual Studio Code Dark Plus theme for JetBrains IDEs
https://plugins.jetbrains.com/plugin/12255-visual-studio-code-dark-plus-theme
BSD 3-Clause "New" or "Revised" License
139 stars 31 forks source link

After IntelliJ update 2024.2, the background is white #73

Closed cosimosacco closed 2 weeks ago

cosimosacco commented 2 weeks ago

What the issue is?

As per title, the background appears white after IntelliJ 2024.2 update. I've already tried disabling/re-enabling, uninstalling/re-installing, restarts, etc...

Screenshots

image

How would you fix it?

N/A

Additional info

Q A
Plugin Version 2.9.0
IDE and version 2024.2
Operating system Windows 10
wimdavies commented 2 weeks ago

+1 for this. FWIW, I had the white background appear when updating to plugin version 2.9.0 + the latest 241 patch of IntelliJ, before patching again to 242 and the plugin issue persisting. (This is on macOS)

samdark commented 2 weeks ago

Interesting. Looks like the editor color schema isn't applied. Would you please re-check if it's selected?

image

wimdavies commented 2 weeks ago

@samdark nice one, yes you're correct, it is not selected in Settings > Editor > Color Scheme:

image

This is despite it being selected in the 'Themes' dialog.

wimdavies commented 2 weeks ago

Manually selecting it as the scheme in the Editor settings successfully applies it to files.

wimdavies commented 2 weeks ago

Hi @samdark, is this completed though? Is it the behaviour at risk of happening again? Can it be fixed automatically for users who don't know about this manual solution? Happy to contribute if that would be useful

samdark commented 2 weeks ago

It happens from time to time but it's not related to the theme itself. It's something within IDE so I cannot fix it.

cosimosacco commented 2 weeks ago

Also in my case, the color scheme was not selected. Thanks for the troubleshoot.

wimdavies commented 2 weeks ago

@samdark understandable, and I'm sorry, that must be frustrating. Is it perhaps worth leaving a note to that effect somewhere in the readme and on the plugin listing with IntelliJ? Via the reviews, I can see other users experiencing this issue periodically, and it seems a shame for something that's out of your hands to be affecting your review score and the reception of your hard work.

samdark commented 2 weeks ago

Yes. Maybe. I'll think about how to note it. Thanks.

wimdavies commented 2 weeks ago

No worries! Thanks again 🙏

wimdavies commented 2 weeks ago

I've left a review on Marketplace that notes the fix and directs people to this discussion, FWIW. Hope that helps.