add Sitemap Images - Githubissues

samdark / sitemap

Sitemap and sitemap index builder

BSD 3-Clause "New" or "Revised" License

530 stars 87 forks source link

add Sitemap Images #56

Closed SunwelLight closed 6 years ago

SunwelLight commented 6 years ago

Added a new class for the generation of site map images.

samdark commented 6 years ago

Overall method overrides are copying too much while changing not so much. It makes sense to extract these into protected methods in the Sitemap class.

agoestri-tkpd commented 6 years ago

Please merge, I need this feature

SunwelLight commented 6 years ago

The duplicating method is removed

samdark commented 6 years ago

@SunwelLight overall it looks good but last two little changes are needed. Also need changes to README.md explaining image sitemap...

samdark commented 6 years ago

Going to push a new version that implements it differently.