search

samdark / sitemap

Sitemap and sitemap index builder
BSD 3-Clause "New" or "Revised" License
530 stars 87 forks source link

Cyrylica error #57

Closed Yuriy-Svetlov closed 6 years ago

Yuriy-Svetlov commented 6 years ago

When i to add URL on Cyrylica - on Russian language", i get error from validation URL.

https://wxm/кекеё5

Why do you make validation URL? I think than it need removed. Validation must don't be related with this lib.

Fatal error: Uncaught InvalidArgumentException: The location must be a valid URL. You have specified: https://wxm/кекеё5. in ...vendor\samdark\sitemap\Sitemap.php:243 Stack trace: #0 ...vendor\samdark\sitemap\Sitemap.php(297): samdark\sitemap\Sitemap->validateLocation('https://wxm..') 
...vendor\samdark\sitemap\Sitemap.php(272): samdark\sitemap\Sitemap->addSingleLanguageItem('https://wxm_...', 1524153061, 'weekly', 0.3) #2 
.../index.php(13): samdark\sitemap\Sitemap->addItem('https://wxm/...', 1524153061, 'weekly', 0.3) #3 {main} 
...vendor\samdark\sitemap\Sitemap.php on line 243
Yuriy-Svetlov commented 6 years ago

I can make. I have made. Few minutes.

Yuriy-Svetlov commented 6 years ago

I fixed https://github.com/samdark/sitemap/pull/58

If exsisx opportunity, write me down as an assistant/contribute )

samdark commented 6 years ago

OK. I'll check it.

samdark commented 6 years ago

Going to remove validation overall soon.