search

samdark / sitemap

Sitemap and sitemap index builder
BSD 3-Clause "New" or "Revised" License
534 stars 86 forks source link

Sitemap overflow fix #83

Closed DarkSilence closed 1 year ago

DarkSilence commented 2 years ago

That's my implementation for a fix for issues #82 and #81 I'm not quite sure about my approach on line 202. Could you check it please.

mougrim commented 1 year ago

@samdark @DarkSilence, Hi! What is needed for merge fix? Do you need some help here? I have the same issue:

PHP Fatal error:  Uncaught OverflowException: The buffer size is too big for the defined file size limit in vendor/samdark/sitemap/Sitemap.php:234
Stack trace:
#0 vendor/samdark/sitemap/Sitemap.php(199): samdark\sitemap\Sitemap->flush()
#1 vendor/samdark/sitemap/Sitemap.php(212): samdark\sitemap\Sitemap->finishFile()
samdark commented 1 year ago

Yes.

Need to verify it works and works correctly.

mougrim commented 1 year ago

Hello! Looks like it doesn't fix OverflowException, I'm preparing separated MR.