samdark / yii2-cookbook

Yii 2.0 Community Cookbook
1.45k stars 297 forks source link

fixed RbacController::actionAssign #136

Closed damasco closed 7 years ago

samdark commented 7 years ago

I think just role is a better name.

damasco commented 7 years ago

@samdark

if (!$role) {
    throw new InvalidParamException("There is no role \"$role\".");
}
samdark commented 7 years ago

Ah. Got the idea. Still, I think the argument should be $role. Let's rename role object instead.

samdark commented 7 years ago

Fixed. Thank you!