fix(types): missing command and result

samdenty / console-feed

Captures console.log's into a React Component 🔥

MIT License

688 stars 109 forks source link

Closed bodinsamuel closed 3 years ago

bodinsamuel commented 3 years ago

add missing types for command and result
noticed the release reverted my prev package.json changes, was it intentional? https://github.com/samdenty/console-feed/commit/824af1505e756d212f15ad4049cf7df26bf6df07

samdenty commented 3 years ago

was it intentional

Yep, the build was failing with them. The types are somehow broken

bodinsamuel commented 3 years ago

Yep, the build was failing with them. The types are somehow broken

Ah let me take a look

bodinsamuel commented 3 years ago

using allowSyntheticDefaultImports seems to do the trick, lmk

bodinsamuel commented 3 years ago

Hey @samdenty can I have some review on this please? ☺️

samdenty commented 3 years ago

the demo seems to be broken with the import * stuff, see browser logs w/ yarn start.

samdenty commented 3 years ago

awesome! published as 3.2.2

bodinsamuel commented 3 years ago

thank you 🙏🏻