search

samdjstevens / java-totp

A java library for implementing Time-based One Time Passwords for Multi-Factor Authentication.
MIT License
422 stars 103 forks source link

Update all dependencies to latest version #17

Closed OlivierJaquemet closed 4 years ago

OlivierJaquemet commented 4 years ago

Mostly updated with https://www.dependabot.com/ which I strongly recommend you to set-up for automatic pull request each time a newer dependency is found.

All tests passed without error (unless you are using java 11, it will require a small rewrite of IOUtils class, but this is unrelated to those dependencies upgrade)

samdjstevens commented 4 years ago

Great, thanks for this! Will look into dependabot. Can you elaborate on the Java 11 issue?

OlivierJaquemet commented 4 years ago

If you try to run the test with java 11, one of them will fail. I will fill a more detailed bug report and provide an appropriate fix. I think this is just scoped to the test api, and probably due to a invalid convertion of bytes/string/base64 due to java 11 default string encoding in utf 16 or something related.

Le jeu. 19 déc. 2019 20:02, Sam Stevens notifications@github.com a écrit :

Great, thanks for this! Will look into dependabot. Can you elaborate on the Java 11 issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samdjstevens/java-totp/pull/17?email_source=notifications&email_token=AAEXC3IJLUGTYPKGOZSYPF3QZPALBA5CNFSM4J5LEUF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHKTAIQ#issuecomment-567619618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXC3LCRXIRHOQT4DRMVLLQZPALBANCNFSM4J5LEUFQ .