Fix rows and columns parameters

samdobson / image_slicer

Split images into tiles. Join the tiles back together.

http://samdobson.github.io/image_slicer

MIT License

151 stars 73 forks source link

Fix rows and columns parameters #17

Closed dc740 closed 5 years ago

dc740 commented 5 years ago

The extra parameter was not being used, so I left one reference, and deleted the reference that prevented me from specifying the number of rows and columns to divide the file.

These could be handy for the command line binary too.

dc740 commented 5 years ago

I didn't realize I wasn't working on another branch so I pushed my new changes. Now I also added support for the slicer binary. It's consistent, I verified it works, and I also verified that not sending the command line parameters causes an error as expected.

samdobson commented 5 years ago

Brilliant! Many thanks for your work on this.