samdoran / ansible-collection-macos

Ansible collection of roles and modules for use on macOS
8 stars 2 forks source link

✨ Add module check mode for `started` state #18

Closed webknjaz closed 1 year ago

webknjaz commented 1 year ago

Prior to this patch, it was attempting to do actual mutation unconditionally.

webknjaz commented 1 year ago

This one is built on top of #17

codecov[bot] commented 1 year ago

Codecov Report

Merging #18 (538dea2) into main (8508b70) will decrease coverage by 0.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   35.67%   35.49%   -0.19%     
==========================================
  Files           5        5              
  Lines         384      386       +2     
  Branches       44       45       +1     
==========================================
  Hits          137      137              
- Misses        247      249       +2     
Flag Coverage Δ
sanity 32.34% <ø> (-0.18%) :arrow_down:
units 82.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...amdoran/macos/plugins/modules/parallels_desktop.py 28.64% <0.00%> (-0.30%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

webknjaz commented 1 year ago

@samdoran this one is straightforward.