samdoran / ansible-collection-macos

Ansible collection of roles and modules for use on macOS
8 stars 2 forks source link

[pre-commit.ci] pre-commit autoupdate #19

Closed pre-commit-ci[bot] closed 1 year ago

pre-commit-ci[bot] commented 1 year ago

updates:

codecov[bot] commented 1 year ago

Codecov Report

Merging #19 (2844e7a) into main (762681d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files           5        5           
  Lines         386      386           
  Branches       48       48           
=======================================
  Hits          137      137           
  Misses        249      249           
Flag Coverage Δ
sanity 32.34% <ø> (ø)
units 82.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

webknjaz commented 1 year ago

@samdoran https://github.com/samdoran/ansible-collection-macos/pull/20 will fix the flake8 v6 crash seen in the pre-commit.ci report.

webknjaz commented 1 year ago

@samdoran could you click "rebase" on the PR? I hope that with the updates to main, this might turn green already.

samdoran commented 1 year ago

I don't think a rebase is necessary since the checkout action usually does a speculative merge when testing.

webknjaz commented 1 year ago

A CI restart, then? It probably ran before those changes.

webknjaz commented 1 year ago

Though, you'd have to restart both GHA and pre-commit.ci which requires a specially crafted comment.

webknjaz commented 1 year ago

The latter can be achieved by posting the following comment: pre-commit.ci run

samdoran commented 1 year ago

pre-commit.ci run

samdoran commented 1 year ago

Not sure why it's not pulling in changes as expected. I'll just rebase this branch.

samdoran commented 1 year ago

Looks like the test failures are the same. I'll investigate.

samdoran commented 1 year ago

Looks like a few more import and compile ignores are needed due to the trailing comma change.

samdoran commented 1 year ago

Those trailing commas result in a lot of tests needing to be skipped. I wonder if we could just change the method signature instead.

I have a feeling once I get the import and compile tests passing, the tests themselves will fail when they try to run.

webknjaz commented 1 year ago

Not sure why it's not pulling in changes as expected. I'll just rebase this branch.

GitHub doesn't always update the ephemeral merge commit that many services use. It usually updates it when the PR is updated, not something external. Only automations that do this manually would work around this.

webknjaz commented 1 year ago

I have a feeling once I get the import and compile tests passing, the tests themselves will fail when they try to run.

Oh, right! I forgot that older Pythons didn't allow trailing commas after **kwargs.