samdoran / ansible-collection-macos

Ansible collection of roles and modules for use on macOS
8 stars 2 forks source link

Allow the CI to be triggered by merge queues #22

Closed webknjaz closed 1 year ago

webknjaz commented 1 year ago

This enables the repo to make use of a gating-like feature that is native to GitHub.

Refs:

codecov[bot] commented 1 year ago

Codecov Report

Merging #22 (bb0508c) into main (5a8c454) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files           5        5           
  Lines         386      386           
  Branches       45       48    +3     
=======================================
  Hits          137      137           
  Misses        249      249           
Flag Coverage Δ
sanity 32.34% <ø> (ø)
units 82.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

samdoran commented 1 year ago

I don think merge queue are available for personal repos. I didn't the see the branch protection setting available.

webknjaz commented 1 year ago

I don think merge queue are available for personal repos. I didn't the see the branch protection setting available.

I'll check the docs but maybe it'll appear after merging this...

webknjaz commented 1 year ago

Oh... you're right:

Pull request merge queues are available in any public repository owned by an organization

Have you considered having an org for your collections? It tend to prefer this approach myself to declutter the profile + get better access to some features like RBAC or have separate rate limits for apps. Even if it's a one-person org, I've found that it can be quite useful :)