search

samdroid-apps / something-for-reddit

A Reddit Client For GNOME (with Gtk+ and Python)
GNU General Public License v3.0
162 stars 14 forks source link

Comments view - what should it be #21

Closed samdroid-apps closed 8 years ago

samdroid-apps commented 8 years ago

Old:

https://camo.githubusercontent.com/f1b0804c0a0eb52bb0aa17f9d01c9bd0f48daa61/687474703a2f2f692e696d6775722e636f6d2f70563865486b702e706e67

New:

https://gyazo.com/c02f398626dfe834e7c10f87978d1d18

This is a design discussion. Ideas appreciated.

tgraven commented 8 years ago

Some of dark theme issues still remain, but could be fixed by manually defining the font color as black.

samdroid-apps commented 8 years ago

Hum. I will investigate if I can have a dark theme for the application css - as it would make more sense to have dark comment backgrounds.

tgraven commented 8 years ago

Maybe sticking to operators like darker() to adjust background colors would work.

samdroid-apps commented 8 years ago

I also used this nice tango table: http://emilis.info/other/extended_tango/

But the issue that I'm facing now is that I have no idea how to detect the dark variant. I can't see a way to do that via css or python. But there must be some way!

brunelli commented 8 years ago

But the issue that I'm facing now is that I have no idea how to detect the dark variant

settings = Gtk.Settings.get_default()
using_dark_variant = settings.get_property("gtk-application-prefer-dark-theme")
samdroid-apps commented 8 years ago

Thanks @brunelli, I just merged a commit that made use of that. We still need to actually write the css for the dark theme, I currently only change the value of $gnome-grey. Contributions always welcome.