samdroid-apps / something-for-reddit

A Reddit Client For GNOME (with Gtk+ and Python)
GNU General Public License v3.0
162 stars 14 forks source link

Settings fails to load after second load #41

Closed julianrichen closed 8 years ago

julianrichen commented 8 years ago

It seems the settings window/dialog fails to load it's content after second load.

Steps to reproduce:

  1. Open Settings
  2. Close Settings
  3. Open Settings Again

No settings load.

From git Master ( 5bbe56b )

Reading the code and uncommenting lines 40 ~ 42 in ./src/settings.py fixes the issue:

if _window is not None:
    _window.show()
    return

My guess is once _window is initialized it's no longer None and immediately returns it without loading it's contents.