MediaRecorder demo is broken by string instead of dict options and mimetypes

samdutton / simpl

Simplest possible examples of HTML, CSS and Javascript:

https://simpl.info

Apache License 2.0

5.19k stars 1.64k forks source link

Closed SingingTree closed 5 years ago

SingingTree commented 5 years ago

The live version of the demo is currently broken on Firefox and Chrome I think there's a couple of things going on:

For the vp8 mime case a dict should be used here.
The mime types used should be similar to video/webm;codecs=vp8. The VP9 case is rejected on Chrome currently because a comma is used to separate the container from the codecs. The vp8 case should use the same style of string.

samdutton commented 5 years ago

Thank you! I'll take a look.

samdutton commented 5 years ago

I fixed it.

I'll close this issue, but let me know if you continue to experience any problems.

Thanks again for the heads-up.

SingingTree commented 5 years ago

Thanks! Related commits for posterity: 1, 2.

samdutton commented 5 years ago

Ah — yes, thanks for adding links to the commits.