Firebase Auth UI - no https prefix for auth domain

samedhi / firemore

Firebase + Clojure -> Firemore

https://firemore.org/

MIT License

19 stars 4 forks source link

Firebase Auth UI - no https prefix for auth domain #53

Closed matusfi closed 4 years ago

matusfi commented 4 years ago

Firebase Auth UI gets its data from the already initialised firebase object. However, it plugs the value from FIREBASE_AUTH_DOMAIN to make an URL that's eventually used to make the auth calls. That's why we should not prefix the auth domain with "https://".

matusfi commented 4 years ago

Hi Stephen! Thanks for making and releasing Firemore. It helps me with developing my app a lot 👍

I have encountered this issue when I tried using the Firebase Auth UI. Hope I left enough info in the PR for you, but if not I'll try to answer any questions you might have.

samedhi commented 4 years ago

Sure, seems reasonable. As you can see, I haven't gotten a whole lot into authentication (past anonymous users) and haven't started storage at all. So I will defer to your experience. Thank you, and sorry it took me so long to notice this!