samedifferent / Ecologics

🌎 A Minecraft mod aiming to improve the Vanilla biomes.
https://www.curseforge.com/minecraft/mc-mods/ecologics
Other
47 stars 30 forks source link

Fix potion recipe not appearing in JEI (Forge exclusive issue) #131

Open VoidLeech opened 6 months ago

VoidLeech commented 6 months ago

Problem

The potion of sliding recipe didn't appear in JEI on Forge.

Cause

ModBrewingRecipe is only a record implementing IBrewingRecipe, while JEI requires additionally that it is a BrewingRecipe, since IBrewingRecipe doesn't require functions with which to retrieve the inputs of the recipe, only the output.

Implemented Fix

Use PotionBrewing.addMix(Potion input, Item ingredient, Potion output) instead. An alternative solution would've been to change ModBrewingRecipe into a class extending BrewingRecipe and changing the relevant code accordingly, but this solution follows the current (working) Fabric implementation more closely. The solution to #55 introduced the ModBrewingRecipe.java file, but its removal in this fix doesn't cause a regression.

Additional Information

Also solves the potion not registering for Create's automated brewing. Functionally doesn't touch the Fabric version, the access widener is just part of common. Tested nonetheless. This issue also persists in 1.19.3 (your default branch). The fix is essentially the same (or entirely) and I would have made a PR targetting the 1.19 branch, but I was getting mixin errors using a version built from the unmodified source and so couldn't test.