search

samedifferent / Ecologics

🌎 A Minecraft mod aiming to improve the Vanilla biomes.
https://www.curseforge.com/minecraft/mc-mods/ecologics
Other
47 stars 31 forks source link

[Bug]: Config option to disable Azalea tree replacement does not affect Azalea trees placed by worldgen #97

Closed bcodegard closed 1 year ago

bcodegard commented 1 year ago

Mod Version

1.19.2-2.1.10

Mod Loader

Forge

Mod Loader Version

43.1.52

What happened?

The config option to disable Azalea tree replacement works for Azalea trees grown from Azalea Bushes and Flowering Azalea Bushes. However, Azalea trees placed by worldgen on top of lush cave biomes are not affected by the config option. Even with the config set to disable Azalea replacement, trees placed by worldgen are generated with Ecologics' azalea logs. I've confirmed that this happens with just Minecraft 1.19.2, Forge 41.3.52 and Ecologics 1.19.2-2.1.10, and no other mods installed.

I've done a bit of testing using the command /place feature

The following two commands result in trees placed with unmodified logs /place feature minecraft:azalea_tree /place feature minecraft:rooted_azalea_tree

The following two commands result in trees placed with Ecologics' logs: /place feature ecologics:azalea_tree /place feature ecologics:rooted_azalea_tree

My best guess is therefore that the feature ecologics:rooted_azalea_tree is still being used by worldgen even when the config option to disable replacement is set.

latest.log

[17Nov2022 14:44:52.527] [Render thread/INFO] [net.minecraft.server.packs.resources.ReloadableResourceManager/]: Reloading ResourceManager: Default, M Resources [17Nov2022 14:44:52.789] [Forge Version Check/INFO] [net.minecraftforge.fml.VersionChecker/]: [forge] Starting version check at https://files.minecraftforge.net/net/minecraftforge/forge/promotions_slim.json [17Nov2022 14:44:53.511] [Forge Version Check/INFO] [net.minecraftforge.fml.VersionChecker/]: [forge] Found status: AHEAD Current: 43.1.52 Target: null [17Nov2022 14:44:58.011] [Render thread/WARN] [net.minecraft.client.sounds.SoundEngine/]: Missing sound for event: minecraft:item.goat_horn.play [17Nov2022 14:44:58.012] [Render thread/WARN] [net.minecraft.client.sounds.SoundEngine/]: Missing sound for event: minecraft:entity.goat.screaming.horn_break [17Nov2022 14:44:58.078] [Render thread/INFO] [net.minecraft.client.sounds.SoundEngine/SOUNDS]: Sound engine started [17Nov2022 14:44:58.254] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas [17Nov2022 14:44:58.263] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 256x128x4 minecraft:textures/atlas/signs.png-atlas [17Nov2022 14:44:58.263] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas [17Nov2022 14:44:58.264] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas [17Nov2022 14:44:58.264] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas [17Nov2022 14:44:58.265] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas [17Nov2022 14:44:58.265] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas [17Nov2022 14:44:59.256] [Render thread/WARN] [net.minecraft.client.renderer.ShaderInstance/]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program. [17Nov2022 14:44:59.454] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas [17Nov2022 14:44:59.456] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas [17Nov2022 14:44:59.458] [Render thread/INFO] [net.minecraft.client.renderer.texture.TextureAtlas/]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas [17Nov2022 14:45:20.690] [Render thread/INFO] [net.minecraft.world.item.crafting.RecipeManager/]: Loaded 7 recipes [17Nov2022 14:45:21.238] [Render thread/INFO] [net.minecraft.advancements.AdvancementList/]: Loaded 1272 advancements [17Nov2022 14:45:28.773] [Server thread/INFO] [net.minecraft.client.server.IntegratedServer/]: Starting integrated minecraft server version 1.19.2 [17Nov2022 14:45:28.774] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Generating keypair [17Nov2022 14:45:28.819] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key server was corrected from null to its default, SimpleCommentedConfig:{}. [17Nov2022 14:45:28.819] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key server.removeErroringBlockEntities was corrected from null to its default, false. [17Nov2022 14:45:28.819] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key server.removeErroringEntities was corrected from null to its default, false. [17Nov2022 14:45:28.819] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key server.fullBoundingBoxLadders was corrected from null to its default, false. [17Nov2022 14:45:28.819] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key server.zombieBaseSummonChance was corrected from null to its default, 0.1. [17Nov2022 14:45:28.820] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key server.zombieBabyChance was corrected from null to its default, 0.05. [17Nov2022 14:45:28.820] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key server.fixAdvancementLoading was corrected from null to its default, true. [17Nov2022 14:45:28.820] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key server.permissionHandler was corrected from null to its default, forge:default_handler. [17Nov2022 14:45:40.469] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Preparing start region for dimension minecraft:overworld [17Nov2022 14:45:41.158] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 0% [17Nov2022 14:45:41.158] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 0% [17Nov2022 14:45:41.488] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 0% [17Nov2022 14:45:42.003] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 0% [17Nov2022 14:45:42.498] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 0% [17Nov2022 14:45:43.005] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 1% [17Nov2022 14:45:43.493] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 2% [17Nov2022 14:45:43.974] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 4% [17Nov2022 14:45:44.480] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 5% [17Nov2022 14:45:45.002] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 6% [17Nov2022 14:45:45.599] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 9% [17Nov2022 14:45:45.979] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 10% [17Nov2022 14:45:46.502] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 13% [17Nov2022 14:45:46.981] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 16% [17Nov2022 14:45:47.493] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 18% [17Nov2022 14:45:47.976] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 22% [17Nov2022 14:45:48.480] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 24% [17Nov2022 14:45:48.988] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 27% [17Nov2022 14:45:49.505] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 30% [17Nov2022 14:45:49.998] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 34% [17Nov2022 14:45:50.496] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 37% [17Nov2022 14:45:50.996] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 40% [17Nov2022 14:45:51.492] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 43% [17Nov2022 14:45:51.987] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 46% [17Nov2022 14:45:52.475] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 49% [17Nov2022 14:45:53.005] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 52% [17Nov2022 14:45:53.476] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 56% [17Nov2022 14:45:53.999] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 60% [17Nov2022 14:45:54.507] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 63% [17Nov2022 14:45:54.999] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 68% [17Nov2022 14:45:55.482] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 70% [17Nov2022 14:45:56.004] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 74% [17Nov2022 14:45:56.495] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 79% [17Nov2022 14:45:56.986] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 84% [17Nov2022 14:45:57.482] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 86% [17Nov2022 14:45:57.995] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 90% [17Nov2022 14:45:58.494] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 93% [17Nov2022 14:45:58.978] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Preparing spawn area: 95% [17Nov2022 14:45:59.438] [Server thread/INFO] [net.minecraftforge.server.permission.PermissionAPI/]: Successfully initialized permission handler forge:default_handler [17Nov2022 14:45:59.457] [Render thread/INFO] [net.minecraft.server.level.progress.LoggerChunkProgressListener/]: Time elapsed: 18985 ms [17Nov2022 14:45:59.540] [Server thread/INFO] [net.minecraft.client.server.IntegratedServer/]: Changing view distance to 18, from 10 [17Nov2022 14:45:59.546] [Server thread/INFO] [net.minecraft.client.server.IntegratedServer/]: Changing simulation distance to 12, from 0 [17Nov2022 14:46:00.643] [Netty Local Client IO #0/INFO] [net.minecraftforge.network.NetworkHooks/]: Connected to a modded server. [17Nov2022 14:46:00.845] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: player joined the game [17Nov2022 14:46:02.536] [Render thread/INFO] [net.minecraft.advancements.AdvancementList/]: Loaded 0 advancements [17Nov2022 14:46:04.123] [Server thread/INFO] [net.minecraft.client.server.IntegratedServer/]: Saving and pausing game... [17Nov2022 14:46:04.138] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:overworld [17Nov2022 14:46:05.161] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:the_nether [17Nov2022 14:46:05.164] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:the_end [17Nov2022 14:46:15.122] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: [player: Teleported player to 5800.500000, 128.000000, 800.500000] [17Nov2022 14:46:15.140] [Render thread/INFO] [net.minecraft.client.gui.components.ChatComponent/]: [System] [CHAT] Teleported player to 5800.500000, 128.000000, 800.500000 [17Nov2022 14:46:15.865] [Server thread/WARN] [net.minecraft.server.MinecraftServer/]: Can't keep up! Is the server overloaded? Running 2028ms or 40 ticks behind [17Nov2022 14:46:38.208] [Render thread/INFO] [net.minecraft.advancements.AdvancementList/]: Loaded 4 advancements [17Nov2022 14:46:42.187] [Server thread/INFO] [net.minecraft.client.server.IntegratedServer/]: Saving and pausing game... [17Nov2022 14:46:42.197] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:overworld [17Nov2022 14:46:42.215] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:the_nether [17Nov2022 14:46:42.216] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:the_end [17Nov2022 14:47:10.820] [Render thread/INFO] [net.minecraft.advancements.AdvancementList/]: Loaded 6 advancements [17Nov2022 14:47:21.758] [Render thread/INFO] [net.minecraft.advancements.AdvancementList/]: Loaded 8 advancements [17Nov2022 14:47:27.039] [Server thread/INFO] [net.minecraft.client.server.IntegratedServer/]: Saving and pausing game... [17Nov2022 14:47:27.043] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:overworld [17Nov2022 14:47:27.054] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:the_nether [17Nov2022 14:47:27.055] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:the_end [17Nov2022 14:47:51.557] [Server thread/INFO] [net.minecraft.server.network.ServerGamePacketListenerImpl/]: player lost connection: Disconnected [17Nov2022 14:47:51.557] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: player left the game [17Nov2022 14:47:51.562] [Server thread/INFO] [net.minecraft.server.network.ServerGamePacketListenerImpl/]: Stopping singleplayer server as player logged out [17Nov2022 14:47:51.613] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Stopping server [17Nov2022 14:47:51.613] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving players [17Nov2022 14:47:51.613] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving worlds [17Nov2022 14:47:54.152] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:overworld [17Nov2022 14:47:54.789] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:the_nether [17Nov2022 14:47:54.790] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[Ecologics tEst v2]'/minecraft:the_end [17Nov2022 14:47:54.805] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: ThreadedAnvilChunkStorage (Ecologics tEst v2): All chunks are saved [17Nov2022 14:47:54.805] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved [17Nov2022 14:47:54.805] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved [17Nov2022 14:47:54.806] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: ThreadedAnvilChunkStorage: All dimensions are saved

samedifferent commented 1 year ago

This is not a bug. The config file option only controls azalea trees grown from azalea bushes. If you want to modify the naturally grown ones, you need to create a datapack. This is due to Forge's new biome modifier system. For a tutorial, reference this: https://github.com/samedifferent/Ecologics/wiki/Ecologics-Configuration-(Forge)